User

Welcome, Guest. Please login or register.
Did you miss your activation email?

Login with username, password and session length
Select language:

Community


Donate

Donate for PortaMx !
Your donation is safe and helps support the issues and causes you care most about.

Stats

Members
  • *Total Members: 4010
  • *Latest: kuki78
Stats
  • *Total Posts: 15656
  • *Total Topics: 2322
  • *Online Today: 23
  • *Most Online: 157
(27 Aug 09, 03:54:53)
Users online
  • *Users: 0
  • *Guests: 17
  • *Total: 17
« previous next »
Pages: [1] 2   Go Down

Author Topic: PortaMx and SimpleSEF test  (Read 7255 times)

0 Members and 1 Guest are viewing this topic.

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
PortaMx and SimpleSEF test
« on: 18 Dec 09, 07:13:39 »
Our site run currently with the SEO mod SimpleSMF on a testphase.
Please tell us, if you see any error.

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline Garry1953

  • Newbie
  • *
  • Posts: 33
    • Artists Online Australia Art Forum
Re: PortaMx and SimpleSEF test
« Reply #1 on: 18 Dec 09, 07:47:53 »
Hi Fel

I notice the .html extension added to the urls I visit a link on your site.

Everything seems to work OK to me. O0
 
Logged

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #2 on: 18 Dec 09, 08:18:55 »
yes .. that's true and correct  ;)

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #3 on: 19 Dec 09, 16:09:48 »
I have stopped the test with SimpleSEF, because it produce a lot of errors and many links don't work correct.

And it looks like the developer is not willing or able to follow his program to the requirements that we place on good software, too. Thus, the matter died for us.

Read the messages up from here:
http://www.simplemachines.org/community/index.php?topic=352351.msg2409619#msg2409619

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #4 on: 17 Jan 10, 21:47:24 »
I have tested the v1.0.2 of SimpleSEF .. but I see the same problems as before.

Dynamic created url like url/index.php?theme=num and url/index.php?language=langname don't work, the theme request ends in a error.
Singepage requests they have a dot in the pagename also don't work..

To get this to work, it's need two small changes, but we don't offer these.
Why not? Yea .. good question .. and the answer:
I see, that Slammeddime have added special codes for SimplePortal...

We see that with very interest and we get the consequences of this ingnorance ...

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline Cool

  • Free Tibet
  • Charter Member
  • *
  • Posts: 714
  • Gender: Male
  • I Hate Chinas Authority
Re: PortaMx and SimpleSEF test
« Reply #5 on: 18 Jan 10, 00:24:48 »
hmmm...what do the others can...what Feline not can do by her self

Feline i think you should do your own seo-mod for your excelent portal and blog
Logged
|I Use: SMF 2.0 | PortaMx 1.4
Q: What do you do when you see a bear in the woods?
A: Play Dead!

H-A-H-L = Happy Admins Have Linux

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #6 on: 18 Jan 10, 00:32:40 »
*lol* ... no, no .. we have enough to do with the next major release of portamx.
# categories and articles
# designed front page
# download manager
and mutch more ...
I think, that is a long run  8)

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline jan.s

  • Full Member
  • ***
  • Posts: 189
  • Gender: Male
    • malawisee.net
Re: PortaMx and SimpleSEF test
« Reply #7 on: 18 Jan 10, 01:07:59 »
yep,
i guess there are more important things than seo :)

is there a roadmap for the next major release?
Logged
gruss
jan


Ich bin ein grosszügiger Mensch. Jeder darf meiner Meinung sein. ;D

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #8 on: 18 Jan 10, 01:34:41 »
yes, that is planned ...
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline Arantor

  • Newbie
  • *
  • Posts: 3
  • Gender: Male
Re: PortaMx and SimpleSEF test
« Reply #9 on: 18 Jan 10, 09:09:22 »
Just wanted to add something here. We checked SSEF very very thoroughly prior to installation on SimpleDesk.net, in light of all your comments, and while yes, there was an issue with theme/language, that was fixed in 1.0.2 - and I can use ?theme=x just fine over on SimpleDesk.

In fact, the only issues we had were related to Project Tools, not to anything else.
Logged

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #10 on: 18 Jan 10, 09:31:06 »
That is not true!
The theme=x and language=lang don't work in SSEF 1.0.2 if the link is dynamically (with javascript) created.
You can simple test that with:
Code: [Select]
global $scripturl;
echo '
<form id="chgtheme" action="'. $scripturl .'" method="post"></form>
<script type="text/javascript"><!-- // --><![CDATA[
document.getElementById("chgtheme").action = "'. $scripturl .'?theme=1";
document.getElementById("chgtheme").submit();
// ]]></script>';
Same for language ..

And a legal request like url/index.php?my.page also don't work.
For this php bug there is an easy and simple solution that has no side effects on the functions SSEF.

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline Arantor

  • Newbie
  • *
  • Posts: 3
  • Gender: Male
Re: PortaMx and SimpleSEF test
« Reply #11 on: 18 Jan 10, 09:48:29 »
1. Code doesn't work for me at all, just does nothing. In any case I'm not entirely sure what that's trying to prove. I note that at no point was this mentioned in the original report.

If you have it forming a proper URL it should be diverting through the 301 redirection anyway, which suggests to me that some other element of configuration may be incorrect.


2. As addressed in the SSEF thread, it may be a valid URL in itself, but PHP doesn't entirely consider it valid - and never has.

http://us2.php.net/manual/en/language.variables.external.php
Quote
Dots in incoming variable names

Typically, PHP does not alter the names of variables when they are passed into a script. However, it should be noted that the dot (period, full stop) is not a valid character in a PHP variable name. For the reason, look at it:

<?php
$varname.ext;  /* invalid variable name */
?>
Now, what the parser sees is a variable named $varname, followed by the string concatenation operator, followed by the barestring (i.e. unquoted string which doesn't match any known key or reserved words) 'ext'. Obviously, this doesn't have the intended result.

For this reason, it is important to note that PHP will automatically replace any dots in incoming variable names with underscores.

So while, yes, you can use index.php?my.page as a legal URL in and of itself, what happens if you ever have index.php?my_page as well? There are times this collision can occur, and as a safeguard, SSEF does not support this method. I also cannot name any other PHP application that supports this method, for this very reason.


EDIT to add: I pointed SlammedDime in this direction, the snippet worked for him just fine. So I possibly did something that broke the snippet when I tried it - but the correct URL was in the generated page source and handled correctly for him.
Logged

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #12 on: 18 Jan 10, 10:40:46 »
Quote from: Arantor on 18 Jan 10, 09:48:29
1. Code doesn't work for me at all, just does nothing. In any case I'm not entirely sure what that's trying to prove. I note that at no point was this mentioned in the original report.
As I say .. the theme id is added dynamically in a javascript variable like
document.getElementById("chgtheme").action = "'. $scripturl .'?theme=" + themeid;

The result is, that SSEF the coded as url/theme/1.
Same on language:
document.getElementById("chglang").action = "'. $scripturl .'?language=" + langname;
is code as url/language/english

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.

Offline Arantor

  • Newbie
  • *
  • Posts: 3
  • Gender: Male
Re: PortaMx and SimpleSEF test
« Reply #13 on: 18 Jan 10, 11:01:29 »
Isn't that was what was fixed in 1.0.2, meaning it should be generating url/theme,1/ style URLs?

Definitely using 1.0.2?
Logged

Offline feline

  • CO PortaMx corp.
  • Administrator
  • *
  • Posts: 5224
  • Gender: Female
Re: PortaMx and SimpleSEF test
« Reply #14 on: 18 Jan 10, 11:16:02 »
Yes, here running SSEF 1.0.2 (see attached image)

And the problem, we see, is the url rewrite .. SSEF see the $scripturl  and the theme=, the themeid is a javascript variable, so the url result is url/theme/id, that must url/theme,id.
the one and only way to get this to work:
add this before // handle unknown variables
Code: [Select]
//> add by PortaMx
elseif($url_array[0] == 'language' || $url_array[0] == 'theme')
{
$querystring[$url_array[0]] = $url_array[1];
array_shift($url_array);
array_shift($url_array);
}
//>

also the special portmax page reques can handled very simple ..
find:
Code: [Select]
  parse_str(!empty($url_parts['query']) ? $url_parts['query'] : '', $params);
replace with:
Code: [Select]
//> modify by PortaMx
  if(!empty($url_parts['query']))
  {
    if(strpos($url_parts['query'], '=') !== false)
    parse_str($url_parts['query'], $params);
    else
      $params[$url_parts['query']] = '';
  }
//>

I have add this small changes and all works perfect.
The 301 redirect we can't use, because the theme and language change itself make a redirect to to url on wich the request started, the redir url is a $_POST value ..

Fel
Logged
Many are stubborn in relation to the path, a few in relation to the target.
Pages: [1] 2   Go Up
« previous next »